feat: add validation on secrets on generated plugin cofigs #5203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5203 +/- ##
=======================================
- Coverage 75.9% 75.8% -0.1%
=======================================
Files 170 170
Lines 19447 19549 +102
=======================================
+ Hits 14767 14837 +70
- Misses 3851 3872 +21
- Partials 829 840 +11 ☔ View full report in Codecov by Sentry. |
randmonkey
force-pushed
the
feat/validate_secrets_for_plugin_config
branch
2 times, most recently
from
f570320
to
ab828ad
Compare
randmonkey
force-pushed
the
feat/validate_secrets_for_plugin_config
branch
2 times, most recently
from
0c6c452
to
0093f43
Compare
randmonkey
force-pushed
the
feat/validate_secrets_for_plugin_config
branch
2 times, most recently
from
9dabe64
to
8134757
Compare
randmonkey
added
area/admission
area/feature
randmonkey
changed the title
mlavacca
reviewed
Dec 6, 2023
randmonkey
force-pushed
the
feat/validate_secrets_for_plugin_config
branch
from
8134757
to
6a92fa8
Compare
randmonkey
force-pushed
the
feat/validate_secrets_for_plugin_config
branch
from
6a92fa8
to
f651698
Compare
mlavacca
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
validates secrets when they are referred by
KongPluginandKongClusterPluginto check if they generate invalid Kong plugin configurations.Which issue this PR fixes:
fixes #5190
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR